Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Additional] Writing automated test #118

Closed
Suraj-Tiwari opened this issue Sep 25, 2018 · 3 comments
Closed

[Additional] Writing automated test #118

Suraj-Tiwari opened this issue Sep 25, 2018 · 3 comments

Comments

@Suraj-Tiwari
Copy link
Contributor

@Trancever @erandagan any plan to work on writing tests ?

@erandagan
Copy link
Contributor

Well most of the logic is really just Facebook's native implementation. Perhaps using Detox for E2E to ensure test ads are being rendered properly and nothing crashes?

@Suraj-Tiwari
Copy link
Contributor Author

Who is going to set up ? as i can't take testing entirely. I have to fix some flow in code

@Trancever
Copy link
Contributor

I think it's a great idea to have Detox tests set up, it would bring a lot of confidence while working with codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants