BREAKING CHANGE: Use promise instead of callback #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guhungry
force-pushed
the
use-promise-instead-of-callback
branch
from
1977b20
to
97c73cb
Compare
Trancever
suggested changes
Jun 5, 2019
guhungry
force-pushed
the
use-promise-instead-of-callback
branch
from
97c73cb
to
d5ce1a1
Compare
|
@guhungry Could you fix eslint errors (you can check it by running |
guhungry
force-pushed
the
use-promise-instead-of-callback
branch
from
d5ce1a1
to
edb9056
Compare
|
@Trancever Done with cherry pick and rebase to master. |
Trancever
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the api use callback pattern instead of easier to use Promise api.
Test Plan
What's required for testing (prerequisites)?
None
What are the steps to reproduce (after prerequisites)?
Test with example app for both Android and iOS
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)