fix: avoid initial animation in (Checkbox|RadioButton).Android (#2349)

callstack · Nov 13, 2020 · 4481d2e · 4481d2e
1 parent 326c1a0
commit 4481d2e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/components/Checkbox/CheckboxAndroid.tsx b/src/components/Checkbox/CheckboxAndroid.tsx
@@ -67,12 +67,19 @@ const CheckboxAndroid = ({
   const { current: scaleAnim } = React.useRef<Animated.Value>(
     new Animated.Value(1)
   );
+  const isFirstRendering = React.useRef<boolean>(true);
 
   const {
     animation: { scale },
   } = theme;
 
   React.useEffect(() => {
+    // Do not run animation on very first rendering
+    if (isFirstRendering.current) {
+      isFirstRendering.current = false;
+      return;
+    }
+
     const checked = status === 'checked';
 
     Animated.sequence([

diff --git a/src/components/RadioButton/RadioButtonAndroid.tsx b/src/components/RadioButton/RadioButtonAndroid.tsx
@@ -77,9 +77,17 @@ const RadioButtonAndroid = ({
     new Animated.Value(1)
   );
 
+  const isFirstRendering = React.useRef<boolean>(true);
+
   const { scale } = theme.animation;
 
   React.useEffect(() => {
+    // Do not run animation on very first rendering
+    if (isFirstRendering.current) {
+      isFirstRendering.current = false;
+      return;
+    }
+
     if (status === 'checked') {
       radioAnim.setValue(1.2);