fix: set line height to Icon (#2350)

callstack · Nov 17, 2020 · eb421bc · eb421bc
1 parent 0fbf3b3
commit eb421bc
Show file tree

Hide file tree

Showing 19 changed files with 108 additions and 0 deletions.
diff --git a/src/components/MaterialCommunityIcon.tsx b/src/components/MaterialCommunityIcon.tsx
@@ -92,6 +92,7 @@ const defaultIcon = ({
     style={[
       {
         transform: [{ scaleX: direction === 'rtl' ? -1 : 1 }],
+        lineHeight: size,
       },
       styles.icon,
     ]}

diff --git a/src/components/__tests__/Appbar/__snapshots__/Appbar.test.js.snap b/src/components/__tests__/Appbar/__snapshots__/Appbar.test.js.snap
@@ -100,6 +100,7 @@ exports[`Appbar does not pass any additional props to Searchbar 1`] = `
               },
               Array [
                 Object {
+                  "lineHeight": 24,
                   "transform": Array [
                     Object {
                       "scaleX": 1,
@@ -217,6 +218,7 @@ exports[`Appbar does not pass any additional props to Searchbar 1`] = `
               },
               Array [
                 Object {
+                  "lineHeight": 24,
                   "transform": Array [
                     Object {
                       "scaleX": 1,
@@ -537,6 +539,7 @@ exports[`Appbar passes additional props to AppbarBackAction, AppbarContent and A
                 },
                 Array [
                   Object {
+                    "lineHeight": 24,
                     "transform": Array [
                       Object {
                         "scaleX": 1,

diff --git a/src/components/__tests__/Checkbox/__snapshots__/Checkbox.test.js.snap b/src/components/__tests__/Checkbox/__snapshots__/Checkbox.test.js.snap
@@ -52,6 +52,7 @@ exports[`renders Checkbox with custom testID 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,
@@ -128,6 +129,7 @@ exports[`renders checked Checkbox with color 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,
@@ -204,6 +206,7 @@ exports[`renders checked Checkbox with onPress 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,
@@ -280,6 +283,7 @@ exports[`renders indeterminate Checkbox 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,
@@ -356,6 +360,7 @@ exports[`renders indeterminate Checkbox with color 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,
@@ -432,6 +437,7 @@ exports[`renders unchecked Checkbox with color 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,
@@ -508,6 +514,7 @@ exports[`renders unchecked Checkbox with onPress 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,

diff --git a/src/components/__tests__/RadioButton/__snapshots__/RadioButton.test.js.snap b/src/components/__tests__/RadioButton/__snapshots__/RadioButton.test.js.snap
@@ -52,6 +52,7 @@ exports[`RadioButton RadioButton with custom testID renders properly 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,
@@ -128,6 +129,7 @@ exports[`RadioButton on default platform renders properly 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,
@@ -204,6 +206,7 @@ exports[`RadioButton on ios platform renders properly 1`] = `
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,
@@ -280,6 +283,7 @@ exports[`RadioButton when RadioButton is wrapped by RadioButtonContext.Provider
           },
           Array [
             Object {
+              "lineHeight": 24,
               "transform": Array [
                 Object {
                   "scaleX": 1,

diff --git a/src/components/__tests__/RadioButton/__snapshots__/RadioButtonGroup.test.js.snap b/src/components/__tests__/RadioButton/__snapshots__/RadioButtonGroup.test.js.snap
@@ -55,6 +55,7 @@ exports[`RadioButtonGroup renders properly 1`] = `
             },
             Array [
               Object {
+                "lineHeight": 24,
                 "transform": Array [
                   Object {
                     "scaleX": 1,

diff --git a/src/components/__tests__/__snapshots__/Avatar.test.js.snap b/src/components/__tests__/__snapshots__/Avatar.test.js.snap
@@ -31,6 +31,7 @@ exports[`renders avatar with icon 1`] = `
         },
         Array [
           Object {
+            "lineHeight": 38.4,
             "transform": Array [
               Object {
                 "scaleX": 1,
@@ -86,6 +87,7 @@ exports[`renders avatar with icon and custom background color 1`] = `
         },
         Array [
           Object {
+            "lineHeight": 38.4,
             "transform": Array [
               Object {
                 "scaleX": 1,