-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve dev workflow #104
Conversation
663236f
to
63117ec
Compare
14c395f
to
672c2f4
Compare
9502670
to
6a81813
Compare
6a81813
to
5343b13
Compare
4760ebb
to
102c151
Compare
@@ -0,0 +1,31 @@ | |||
/* eslint-disable import/no-commonjs */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satya164 is this for watching changes in the library instead of manually copying?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
"react-native-drawer": "^2.3.0" | ||
}, | ||
"scripts": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satya164 Just curious why did you move scripts to the bottom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just easier to find at bottom
example/rn-cli.config.js
Outdated
/* eslint-disable prettier/prettier */ | ||
return blacklist([ | ||
new RegExp( | ||
`^${escape(path.resolve(__dirname, '..', 'node_modules'))}\\/.*$`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing comma crashes the packager for me
example/rn-cli.config.js
Outdated
`^${escape(path.resolve(__dirname, '..', 'node_modules'))}\\/.*$`, | ||
), | ||
new RegExp( | ||
`^${escape(path.resolve(__dirname, '..', 'docs', 'node_modules'))}\\/.*$`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@satya164 Other than the trailing comma issue in |
Damn, the |
Includes #101 and #102.