Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak in Menu hide animation #1965

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

brunohkbx
Copy link
Collaborator

Summary

Unmounting a Menu was causing memory leaks because the animation wasn't properly handled.
Animation invokes the completion callback with {finished: true}

Reference

https://reactnative.dev/docs/animated#working-with-animations

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@Trancever Trancever merged commit eb67a20 into master Jun 18, 2020
@Trancever Trancever deleted the fix/menu-hide-animation branch June 18, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants