fix: fix showing unwanted rotations in header back btn on state changes #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BatDroid Just one question, is this issue happening only on 4.0 branch or also on master? |
Trancever
approved these changes
Jul 16, 2020
Trancever
pushed a commit
that referenced
this pull request
Jul 16, 2020
|
Please see #2082 I believe this may have broken Expo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to this issue.
Here is how the icon is passed, and causing this condition to fail every time and causing a re-render/rotation animation. I also decided to extract the icon to a new file/component.
Test plan