fix: added ref support to button and touchable ripple component. #3992
Conversation
|
Hey @sangameshsomawar, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
sangameshsomawar
force-pushed
the
fix/button-ref
branch
from
3900fc9
to
9c4373e
Compare
lukewalczak
changed the title
|
@lukewalczak Let me know if I can do something more to help reviewing/testing code? |
|
|
||
| type ButtonRef = React.ElementRef<typeof TouchableRipple>; | ||
|
|
||
| const Button: React.ForwardRefRenderFunction<ButtonRef, Props> = ( |
There was a problem hiding this comment.
Have you tried something like this?
| const Button: React.ForwardRefRenderFunction<ButtonRef, Props> = ( | |
| const Button = forwardRef({ |
There was a problem hiding this comment.
@DimitarNestorov I could not understand your point.
forwardRef is already added in the last line export default forwardRef(Button);
There was a problem hiding this comment.
I would prefer if we do not explicitly set the type of Button.
There was a problem hiding this comment.
@DimitarNestorov We cannot use forwardRef from src/utils/forwardRef.tsx because it does not support mentioning component level attribute, In our case TouchableRipple.supported = true; is a component level attribute.
Fixes: #3988
Summary
Added ref support for Button and TouchableRipple component.
Test plan
I tried creating ref for button and touchable ripples, it worked.