fix: forward ref to snackbar #3998
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
lukewalczak
assigned lukewalczak and DimitarNestorov and unassigned lukewalczak and DimitarNestorov
tjaniczek
reviewed
Jul 25, 2023
| }, | ||
| style, | ||
| ]} | ||
| ref={ref} |
There was a problem hiding this comment.
What would be the use case of having ref on Surface? Maybe we should pass ref from renderChildrenWithWrapper so the user can check if the Snackbar is currently open? WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3976
Summary
Provide
refto theSnackbar.Test plan