Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent slider from overflowing out of the container in Web #176 #177

Merged
merged 2 commits into from
May 11, 2020

Conversation

Sharcoux
Copy link
Contributor

Signed-off-by: François BILLIOUD f.billioud@gmail.com

Summary:

Fix for #176

Can be tested with @sharcoux/slider version 2.0.16

I'm working on a sandbox.

Signed-off-by: François BILLIOUD <f.billioud@gmail.com>
@Sharcoux
Copy link
Contributor Author

@Sharcoux
Copy link
Contributor Author

Sharcoux commented Apr 30, 2020

Hum... the snack doesn't succeed to read my lib. But I am currently using it in my project and it's working fine. I think the error is caused by an other lib used by snack. Can anyone confirm that @sharcoux/slider 2.0.16 is working fine on their side?

Unable to resolve module 'module://react-dom/unstable-native-dependencies.js'
  Evaluating module://react-dom/unstable-native-dependencies.js
  Evaluating module://@sharcoux/slider.js
  Evaluating module://App.js.js
  Loading module://App.js
Error: Unable to resolve module 'module://react-dom/unstable-native-dependencies.js'
    at Object.eval (module://react-dom/unstable-native-dependencies.js!transpiled:1:113)
    at eval (module://react-dom/unstable-native-dependencies.js!transpiled:2:4)
    at eval (module://react-dom/unstable-native-dependencies.js!transpiled:3:3)
    at eval (<anonymous>)
    at [snack internals]
    at Object.n ([snack internals]
    at e.evaluate ([snack internals]
    at He ([snack internals]
    at [snack internals]
    at https://snack.expo.io/web-player/37/static/js/app.f96dfdba.chunk.js:1:15647

The changes I made cannot possibly have caused this.

@Sharcoux
Copy link
Contributor Author

Sharcoux commented May 4, 2020

Ok, I think the Snack error is fixed. You can check that it is working on this link : https://snack.expo.io/@sharcoux/sharcoux-react-native-slider-web-implementation
@michalchudziak this should probably be merged ASAP.

Signed-off-by: François BILLIOUD <f.billioud@gmail.com>
@wojteg1337 wojteg1337 merged commit 3636b68 into callstack:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants