Fix #179 : value not being updated on change #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharcoux
changed the title
EvanBacon
approved these changes
May 24, 2020
EvanBacon
reviewed
May 24, 2020
| @@ -167,6 +167,7 @@ const RCTSliderWebComponent = React.forwardRef( | |||
| const containerSize = React.useRef({width: 0, height: 0}); | |||
| const containerRef = forwardedRef || React.createRef(); | |||
| const [value, setValue] = React.useState(initialValue || minimumValue); | |||
| React.useLayoutEffect(() => updateValue(initialValue), [initialValue]) | |||
There was a problem hiding this comment.
Please fix the lint error then we can merge.
|
@Sharcoux Thank you for those PRs we'd like to merge them in - could you take a look at lint issues? |
michalchudziak
approved these changes
May 25, 2020
brentvatne
reviewed
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix issue #179
Test Plan: