Fix regression from #186 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value is not correctly changed, preventing initial value to be set and to reach min and max values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A regression was introduced in PR #186
https://github.com/react-native-community/react-native-slider/pull/186/files#diff-5847c2317e1d89fb73fd4d87ff989ce6R253
where
onValueChange(withinBounds);became
onValueChange(value);Therefore value is not correctly changed, preventing to reach min and max values
Test Plan:
Test with a slider from 0 to 100 (%) with step of 1.
Trying to slide to min and max.
Before
Cannot reach 0 and 100
After
Able to reach 0 and 100