Fix: ignored step value during dragging #393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #390
It allows to successfully use the
step
property which is considered during dragging and during programmatically control of the Slider.The root cause of this issue was that the controlled
value
property modified the dragging logic changing the way the value is passed toRNCSlider
instance according to sliding start and progress.Due to that the
value
was given the unclipped value (uncalculated) during dragging which was assigned to the thumb only, but at the finish of the dragging thevalue
of the whole component received the calculated one.This resulted in observed smooth thumb transition, while
value
having the values respecting thestep
property.The implementation of the fix moves the calculation of the discrete value which calculates the value according to the given step (if no step is given, the transition remains smooth).
The internal
discreteValue
calculation is utilized in both Slider Manager and Slider instance itself.The results of the fix are presented below:
390-repro-fix.mov