Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: move postinstall script to prepack #433

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

rborn
Copy link
Contributor

@rborn rborn commented Sep 27, 2022

Summary:

Fixes #430

Test Plan:

Can't really test as it seems it needs to be packed first? I tried pointing to my fork, but it complains 😅

@BartoszKlonowski
Copy link
Member

Thanks @rborn!
No worries, I'll test it and merge today or tomorrow.

Copy link
Member

@BartoszKlonowski BartoszKlonowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks!

@BartoszKlonowski BartoszKlonowski merged commit e935c97 into callstack:main Sep 27, 2022
@samuelfreiberg
Copy link

When are new releases published? When will this fix be versioned? We're running into this same issue as well

@BartoszKlonowski
Copy link
Member

@samuelfreiberg Please expect the release tomorrow (04.10).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postinstall copy of readme should be removed
3 participants