Fix missing header guard #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
approved these changes
Apr 11, 2024
BartoszKlonowski
approved these changes
Apr 11, 2024
| @@ -1,4 +1,6 @@ | |||
| #ifdef ANDROID | |||
| #pragma once | |||
There was a problem hiding this comment.
Ah, yes! That's mine mistake - I got confused #ifdef with ifndef and suggested removing once during review of new arch measurement PR #589. 🙇♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When compiling for the new architecture the build fails on android because of a missing header guard in
RNCSliderMeasurementsManager.hTest Plan:
Issue can be reproduced in the example app in the repo. Adding the guard compiles successfully.