Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update render flow type with new option unstable_validateStringsRenderedWithinText #1179

Merged

Conversation

pierrezimmermannbam
Copy link
Collaborator

Summary

Adds new option unstable_validateStringsRenderedWithinText to renderOptions type in flow types

Test plan

I don't know how to test flow types, is there a recommended way to do so ?

Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mdjastrzebski mdjastrzebski merged commit 17e2021 into callstack:main Oct 17, 2022
@mdjastrzebski
Copy link
Member

We have flow check but it only checks is typedef is syntactically correct. There is no check that would verify whether the flow types match TS code.

@AugustinLF
Copy link
Collaborator

Just move it to flow-typed and it's not our problem anymore 👀

@mdjastrzebski
Copy link
Member

Already merged ;-)

@AugustinLF
Copy link
Collaborator

Yeah I know, was just saying that for the next one ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants