Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feature: fireEvent default event object #1258

Closed
wants to merge 5 commits into from

Conversation

mdjastrzebski
Copy link
Member

Summary

Resolves #714

Test plan

TODO

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 94.94% // Head: 94.87% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (eed9309) compared to base (ecb4b95).
Patch coverage: 93.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
- Coverage   94.94%   94.87%   -0.08%     
==========================================
  Files          45       46       +1     
  Lines        3088     3159      +71     
  Branches      457      466       +9     
==========================================
+ Hits         2932     2997      +65     
- Misses        156      162       +6     
Impacted Files Coverage Δ
src/fireEvent.ts 95.67% <88.88%> (-2.99%) ⬇️
src/helpers/create-event.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdjastrzebski mdjastrzebski changed the title feature: fireEvent default event object [WIP] feature: fireEvent default event object Dec 28, 2022
@mdjastrzebski
Copy link
Member Author

Closing as stale. Subject will be addressed in UserEvent PR (#1405, #1386 #1396), and can be back-ported to fireEvent if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: fireEvent should provide generated event object
1 participant