Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: immediate setState in useEffect for unstable_validateStringsRenderedWithinText #1612

Merged
merged 2 commits into from
May 23, 2024
Merged

fix: immediate setState in useEffect for unstable_validateStringsRenderedWithinText #1612

merged 2 commits into from
May 23, 2024

Conversation

precious-void
Copy link
Contributor

@precious-void precious-void commented May 20, 2024 •
edited

Summary

Referencing: #1611
Fixed by checking for the renderer to be initialized for the first update received from the Profiler onRender

Test plan

Implemented 2 test for that case:

  1. Positive test that was failing before this implemented fix.
  2. Negative test to check that error is still thrown when text is rendered not inside of the Text tag

@precious-void precious-void force-pushed the fix-validateStringRenderedWithinText branch from 06674b9 to 837c1b8 Compare May 20, 2024 20:07
@mdjastrzebski mdjastrzebski merged commit 76de7d2 into callstack:main May 23, 2024
5 checks passed
@precious-void precious-void deleted the fix-validateStringRenderedWithinText branch May 23, 2024 11:07
@mdjastrzebski
Copy link
Member

This PR has been released with v12.5.1 🎉

@vaniaborges vaniaborges mentioned this pull request Jun 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjastrzebski mdjastrzebski mdjastrzebski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@precious-void @mdjastrzebski