Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add screen API #994

Merged
merged 8 commits into from Jun 24, 2022
Merged

feat: add screen API #994

merged 8 commits into from Jun 24, 2022

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Jun 23, 2022

Summary

Simple screen implementation to match RTL feature.

https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#not-using-screen

Test plan

  • basic screen related tests added

Steps

  • Implementation
  • Tests
  • Docs
  • Flow types

src/pure.ts Outdated Show resolved Hide resolved
website/docs/API.md Outdated Show resolved Hide resolved
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, this is good. Makes us way closer to a typical RTL usage now 🎉

@thymikee thymikee changed the title feature: screen feat: add screen API Jun 24, 2022
@thymikee thymikee merged commit 5d68179 into main Jun 24, 2022
@thymikee thymikee deleted the feature/screen branch June 24, 2022 11:17
creature-water-valley added a commit to ws-4020/mobile-app-crib-notes that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants