-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add NextJS example #367
Conversation
|
Lovely! |
I believe we still need some things to be complete here @thymikee. I'm working with @kbieganowski on this one ;) |
Unfortunately, at the moment we're experiencing issues with building the Next example using Bob. Based on the information provided by @kbieganowski, the issues appears to lie in Next custom tags used for things like styling. This is related to how Bob handles babel and the fact, that Next.js currently doesn't play well with this setup. That being said, because this will always only be a problem in our repo, I recommended to adjust the example so that it doesn't use those custom tags. When a Next.js user downloads reassure package, they will not have this issue, because they will not have to build our internal Next.js example, they would have gotten a built library. We should at the same time mention this in our documentation so that w don't focus potential users who want to play around. We could also provide a hint on hacking the setup in order to make it work if we know how to do it. |
examples/web-nextjs/README.md
Outdated
@@ -0,0 +1,38 @@ | |||
This is a [Next.js](https://nextjs.org/) project bootstrapped with [`create-next-app`](https://github.com/vercel/next.js/tree/canary/packages/create-next-app). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls update this README file to explain that this is plain NextJS app straight from the CLI tool with Reassure atteched. And how to run the reassure tests.
@@ -0,0 +1,33 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls use yarn
to install packages, as all other examples use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that both yarn.lock and package-lock.json (NPM) are present. Pls remove NPM's one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
package.json
Outdated
@@ -71,7 +71,8 @@ | |||
"workspaces": { | |||
"packages": [ | |||
"packages/*", | |||
"examples/native" | |||
"examples/native", | |||
"examples/web-nextjs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not add nextjs here. All examples except from examples/native
are not using monorepo, as this causes version conflicts for react versions/etc
"examples/web-nextjs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
@kbieganowski cc: @mdjastrzebski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! There are still some small bits to iron out. It looks like the issues with custom tags have been dealt with as far as I can see, nice!
We still need to update ESLint rules and align code styling to match our prettier config.
Looks good! Awesome work @kbieganowski and @Xiltyn. Let's fix the lint, I think we can simply disable linting in examples/web-nextjs. Also let's update examples Readme file, to describe our example rather than NextJS default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we're good here, there is a small ReadMe file update, but it's a minor thing I will ammend before merge if necessary.
Remove nextjs example from monorepo workspaces
Summary
Added NextJS example based on Vite tests in
examples/web-vite
(#226)