Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename meassurePerformance to measureRenders #433

Merged
merged 9 commits into from
Jan 5, 2024

Conversation

mdjastrzebski
Copy link
Member

Summary

Rename measurePerformance to measureRenders to clarify it's meaning when we now also have measureFunction feature. The legacy alias is still available with a deprecation notice.

Test plan

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 41f6a1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/reassure-measure Minor
reassure Minor
test-app-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Performance Comparison Report

  • Current: 12a4c2b - 2024-01-05 10:19:01Z
  • Baseline: main (d4a2001) - 2024-01-05 10:18:11Z

Significant Changes To Duration

Name Type Duration Count
fib 32 function 232.4 ms → 244.3 ms (+11.9 ms, +5.1%) 🔴 1 → 1
fib 31 function 152.4 ms → 144.9 ms (-7.5 ms, -4.9%) 1 → 1
Show details
Name Type Duration Count
fib 32 function Baseline
Mean: 232.4 ms
Stdev: 6.3 ms (2.7%)
Runs: 248.8 237.5 231.5 231.1 229.8 229.4 229.3 228.9 228.8 228.6

Current
Mean: 244.3 ms
Stdev: 0.9 ms (0.4%)
Runs: 246.8 244.2 244.1 244.1 244.0 244.0 244.0 244.0 243.9 243.9
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 152.4 ms
Stdev: 5.1 ms (3.3%)
Runs: 158.5 156.3 156.0 155.5 152.3 152.1 151.6 151.6 149.7 140.2

Current
Mean: 144.9 ms
Stdev: 9.6 ms (6.6%)
Runs: 161.5 157.7 157.1 140.0 139.2 139.2 139.0 138.9 138.8 138.0
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 196.7 ms → 192.5 ms (-4.2 ms, -2.1%) 7 → 7
fib 30 function 88.3 ms → 90.5 ms (+2.2 ms, +2.5%) 1 → 1
Other Component 10 render 117.3 ms → 119.2 ms (+1.9 ms, +1.6%) 4 → 4
Other Component 10 legacy scenario render 120.5 ms → 121.0 ms (+0.5 ms, ±0.0%) 4 → 4
Other Component 20 render 120.8 ms → 120.6 ms (-0.2 ms, ±0.0%) 4 → 4
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 196.7 ms
Stdev: 5.7 ms (2.9%)
Runs: 205 202 202 201 197 196 194 192 190 188

Current
Mean: 192.5 ms
Stdev: 5.9 ms (3.1%)
Runs: 198 198 198 197 196 192 190 188 187 181
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
fib 30 function Baseline
Mean: 88.3 ms
Stdev: 3.2 ms (3.6%)
Runs: 95.0 91.8 91.3 87.6 86.5 86.2 86.1 86.1 86.1 86.0

Current
Mean: 90.5 ms
Stdev: 0.9 ms (1.0%)
Runs: 93.0 90.4 90.3 90.3 90.3 90.2 90.2 90.2 90.2 90.1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Other Component 10 render Baseline
Mean: 117.3 ms
Stdev: 4.2 ms (3.6%)
Runs: 123 121 121 120 118 117 117 114 112 110

Current
Mean: 119.2 ms
Stdev: 4.0 ms (3.4%)
Runs: 125 124 123 120 120 119 118 115 114 114
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 10 legacy scenario render Baseline
Mean: 120.5 ms
Stdev: 6.2 ms (5.1%)
Runs: 134 124 124 122 121 119 119 115 114 113

Current
Mean: 121.0 ms
Stdev: 3.8 ms (3.2%)
Runs: 125 124 124 124 123 123 119 117 116 115
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 20 render Baseline
Mean: 120.8 ms
Stdev: 5.5 ms (4.5%)
Runs: 135 128 125 125 124 123 123 122 122 122 121 120 120 118 117 116 115 115 113 112

Current
Mean: 120.6 ms
Stdev: 5.1 ms (4.3%)
Runs: 132 127 127 124 124 123 123 123 122 121 121 120 120 118 117 116 115 114 113 112
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Changes To Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 41f6a1e

@mdjastrzebski mdjastrzebski changed the title refactor: rename meassure performance refactor: rename meassurePerformance to measureRenders Jan 3, 2024
docusaurus/docs/api.md Outdated Show resolved Hide resolved
@mdjastrzebski mdjastrzebski merged commit 4352279 into main Jan 5, 2024
2 checks passed
@mdjastrzebski mdjastrzebski deleted the refactor/rename-meassure-performance branch January 5, 2024 10:30
mdjastrzebski added a commit that referenced this pull request Feb 21, 2024
* refactor: rename measurePerformance to measureRenders

* refactor: expose legacy `measurePerformance` alias

* chore: file naming

* chore: add changeset

* refactor: add `writeFile` option

* refactor: warn once

* docs: tweaks

* refactor: rename MeasureRendersOptions

* refactor: rename resetToDefaults
mdjastrzebski added a commit that referenced this pull request Feb 21, 2024
* refactor: rename `meassurePerformance` to `measureRenders` (#433)

* refactor: rename measurePerformance to measureRenders

* refactor: expose legacy `measurePerformance` alias

* chore: file naming

* chore: add changeset

* refactor: add `writeFile` option

* refactor: warn once

* docs: tweaks

* refactor: rename MeasureRendersOptions

* refactor: rename resetToDefaults

* refactor: cleanup logger exports (#434)

* chore: yarn upgrade

* refactor: cleanup logger exports

* chore: add change sets

* chore: upgrade deps 2024-01-05 (#435)

* chore: update some deps

* chore: upgrade babel

* chore upgrade types

* chore: upgrade line

* chore: upgrade react-native

* fix: fix logger outputing undefined in report

* chore: upgrade danger and turborepo

* chore: upgrade eslint config (#437)

* chore: upgrade eslint config

* refactor: fix issues

* chore: update test-app

* chore: fix ts

* chore: update snapshots

* chore: ignore `lib` in test

* chore: fix tests

* chore: fix ci dangerfile

* chore: simplify folder structure (#438)

* refactor: revert measureRenders name

# Conflicts:
#	packages/measure/CHANGELOG.md
#	packages/reassure/CHANGELOG.md
#	test-apps/native/CHANGELOG.md

* refactor: revert reset to defaults rename

* chore: reformat

* refactor: revert measureRender rename
mdjastrzebski added a commit that referenced this pull request Feb 21, 2024
* refactor: rename measurePerformance to measureRenders

* refactor: expose legacy `measurePerformance` alias

* chore: file naming

* chore: add changeset

* refactor: add `writeFile` option

* refactor: warn once

* docs: tweaks

* refactor: rename MeasureRendersOptions

* refactor: rename resetToDefaults
mdjastrzebski added a commit that referenced this pull request Jun 16, 2024
* refactor: rename `meassurePerformance` to `measureRenders` (#433)

* chore: v1.0.0-beta

* docs: update changelogs

* docs: migration guide

* chore: update snapshots

* chore: update node ver on GH

* chore: v1.0.0-rc

* chore: v1.0.0-rc.1

* chore: reorganize repo deps (#477)

* refactor: migrate deps

* chore: dedup eslint

* chore: fix eslint deps

* chore: yarn berry (#478)

* chore: yarn berry (wip)

chore: forward reassure cli in the main package

chore: remove --force

chore: fix ci

chore: fix ci

chore: fix typecheck

chore: fix danger

chore: fix danger

chore: fix ci

chore: fix danger

refactor: tweaks

* chore: workspace deps

* chore: add changeset

* chore: v1.0.0-rc.2

* chore: fix versions

* chore: fix version deps between packages

* chore: v1.0.0-rc.3

* fix: iso date milliseconds regex (#481)

* chore: check deps consistency (#482)

* chore: pdate deps 2024-05-09 (#484)

* chore: update deps

* chore: fix lint

* chore: update danger (#483)

chore: update danger.js

* chore: upgrade RN / test app (#485)

* chore: upgrade turbo

* chore: update React Native / test app

* chore: fix wasm error

* chore: updata other deps (#486)

* chore: update other deps

* chore: update peer deps

* chore: update deps

* feat: enable wasm by default (#488)

* chore: tweak workflow (#490)

* chore: tweak workflow

* chore: update docs

* chore: export types (#489)

* chore: export types

* chore: gen yarn.lock

* chore: tweaks docs

* refactor: rename types

* chore: add docs

* chore: clean scripts (#491)

* chore: clean scripts

* chore: tweak turbo

* chore: add missing changeset

* chore: v1.0.0-beta.4

* chore: regenerate yarn.lock

* feat: detect unnecessary render and warn user (#468)

* feat: detect unnecessary render and warn user

feat: capture json representations in an array to compare after for unnecessary rendering

fix: get current testingLibrary for comparasion only react-native for now

fix: save json representation instead of string for rendered component state and compare changes between states using dfs

fix: test name

fix: update comparasion function and save compare results into output.json and show comparation results in the end of the test

fix: update interface and variable names based on pr recommendatations

chore: rebase to v1

* refactor: improve output formatting

* refactor: fix typo

* refactor: remove unnecessary warning

* refactor: improve testing

* refactor: improve report criteria

* refactor: improve naming

* refactor: improve code structure & tests

* refactor: tweaks

* feat: improve markdown output

* refactor: custom tree comparer

* refactor: clean up code

* refactor: update JSON structure

* refactor: use "initial update count" naming

* chore: fix lint

* chore: improve tests

* refactor: tweaks

* docs: update

* refactor: self code review

* docs: tweaks

* chore: add changeset

* refactor: final tweaks

---------

Co-authored-by: Guven Karanfil <guven.karanfil@smartface.io>
Co-authored-by: Maciej Jastrzebski <mdjastrzebski@gmail.com>

* chore: v1.0.0-rc.5

* chore: fix yarn.lock

* chore: fix reassure-tests.sh

---------

Co-authored-by: Güven Karanfil <40958989+guvenkaranfil@users.noreply.github.com>
Co-authored-by: Guven Karanfil <guven.karanfil@smartface.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants