Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: native build config for Android #639

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Jun 7, 2024

Summary

  • fixed CMake config
  • removed buildTools version from config - was causing a warning and other libs don't use this field anymore

Test plan

  • - TesterApp android builds

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 10:16am

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: fffe21b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and app works correctly now! 🚀

@jbroma jbroma merged commit 13db9ed into main Jun 7, 2024
5 checks passed
@jbroma jbroma deleted the fix/native-build-android branch June 7, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants