chore: tweaks

callstack · May 6, 2024 · 2816f32 · 2816f32
1 parent ce9de89
commit 2816f32
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/src/constructs/__tests__/unicode.test.tsx b/src/constructs/__tests__/unicode.test.tsx
@@ -81,6 +81,23 @@ test('`unicodeChar` nesting matching', () => {
   ).not.toMatchString('b');
 });
 
+test('`unicodeChar` edge cases handling', () => {
+  expect(() => u(unicodeChar(NaN))).toThrowErrorMatchingInlineSnapshot(
+    `""unicodeChar": expected valid unicode code point but got: NaN"`,
+  );
+  expect(() => u(unicodeChar(1.5))).toThrowErrorMatchingInlineSnapshot(
+    `""unicodeChar": expected valid unicode code point but got: 1.5"`,
+  );
+  expect(() => u(unicodeChar(-1))).toThrowErrorMatchingInlineSnapshot(
+    `""unicodeChar": expected valid unicode code point but got: -1"`,
+  );
+  expect(() => u(unicodeChar(0x110000))).toThrowErrorMatchingInlineSnapshot(
+    `""unicodeChar": expected valid unicode code point but got: 1114112"`,
+  );
+
+  expect(u(unicodeChar(0x10ffff))).toEqualRegex(/\u{10ffff}/u);
+});
+
 test('`unicodeProp` pattern', () => {
   expect(unicodeProp('General_Category', 'Letter')).toEqualRegex(/\p{General_Category=Letter}/);
   expect(unicodeProp('Letter')).toEqualRegex(/\p{Letter}/);

diff --git a/src/constructs/unicode.ts b/src/constructs/unicode.ts
@@ -13,12 +13,8 @@ import type { CharacterEscape } from '../types';
  * @returns A character class representing the unicode escape.
  */
 export function unicodeChar(codePoint: number): CharacterEscape {
-  if (!Number.isInteger(codePoint)) {
-    throw new TypeError('Expected an integer code point but got: ' + codePoint);
-  }
-
-  if (codePoint < 0) {
-    throw new RangeError('Code point must be a positive integer but got: ' + codePoint);
+  if (!Number.isInteger(codePoint) || codePoint < 0 || codePoint > 0x10ffff) {
+    throw new RangeError('"unicodeChar": expected valid unicode code point but got: ' + codePoint);
   }
 
   let escape =