Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: common patterns infrastructure (hex color) #72

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Mar 12, 2024

Summary

First of the series of common patters: hex color.

This PR defined finder and validator variants for hex color pattern.

Note this feature will not be yet mentioned in the documentation to confirm that commonjs/esm import works as intended after release.

Test plan

@mdjastrzebski mdjastrzebski marked this pull request as ready for review March 13, 2024 21:55
@mdjastrzebski mdjastrzebski changed the title feat: feat common patterns (hex color) feat: base common patterns (hex color) Mar 13, 2024
@mdjastrzebski mdjastrzebski changed the title feat: base common patterns (hex color) feat: common patterns infrastructure (hex color) Mar 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 98.21%. Comparing base (91663a7) to head (8406c49).

Files Patch % Lines
src/patterns/hex-color.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #72      +/-   ##
===========================================
- Coverage   100.00%   98.21%   -1.79%     
===========================================
  Files           14       15       +1     
  Lines          165      168       +3     
  Branches        39       39              
===========================================
  Hits           165      165              
- Misses           0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdjastrzebski mdjastrzebski merged commit 39f4cda into main Mar 14, 2024
4 checks passed
@mdjastrzebski mdjastrzebski deleted the feat/patterns branch March 14, 2024 11:13
@mdjastrzebski
Copy link
Member Author

Released in v1.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants