Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes path resolution in tests on windows #12

Merged
merged 1 commit into from Mar 6, 2017

Conversation

piotr-cz
Copy link

When running tests on windows, the test should accept dest fails due to path resolution:

AssertionError: expected [ 'test\\foo-abc.js', 'test\\world' ] to equal [ 'test/foo-abc.js', 'test/world' ] (at '0', A has 'test\\foo-abc.js' and B has 'test/foo-abc.js')

Because path separator on windows is \\ and not /

Reference: Tips for Writing Portable Node.js Code

@callumacrae
Copy link
Owner

Thanks! Sorry for the huge delay.

@callumacrae callumacrae merged commit 6cb4e66 into callumacrae:master Mar 6, 2017
@piotr-cz piotr-cz deleted the patch-1 branch March 6, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants