Line continuation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metatoaster
force-pushed
the
line_continuation
branch
2 times, most recently
from
3e5ee6c
to
d4f1917
Compare
- Preparing for reuse in testing of other lexer classes.
- Define a standard function that will produce a token with those filled in. - Implement line terminator sequence as per ECMA-262 specification. - Also fix a very apparent bug in test case where the 'exc` string is on the next line but was reported to be part of the original line, one of various cases that will upset the line count. - Also force unicode_literals on the es5 lexer module.
metatoaster
force-pushed
the
line_continuation
branch
from
d4f1917
to
b6ecc4e
Compare
- Actually provide line continuation in strings that complies to the specification, which the fix provided by rspivak/slimit#24 was problematic (breaks position tracking) and incomplete as it amounted to no more than a clumsy workaround (come on, duplicated regex code). - Also provide the expected minified output that would strip out these line continuation fragments.
metatoaster
force-pushed
the
line_continuation
branch
from
b6ecc4e
to
9755795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the token production so that the lineno/colno is more consistently applied for more correct token reporting, and also properly handle line continuation in strings so that they do not get prematurely mangled which again breaks tracking of positions. Naturally, implement a way that ensures the minified output remains unchanged (i.e. with the line continuation normalised).