Fix issue with minified drop semicolon output #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A backup check to ensure that the minified code done in this manner remain valid.
- As it turns out, junking meant that the length offsets are no longer matched up, so that the wrong offset was used during the dropping of actual layout chunk rules, which can result in too many rule chunks dropped when multiple drops are effected within the same run. - Show how this can happen with a real unparser and a simulated example convert a typical interspersed output to drop the rules of the inner node.
metatoaster
force-pushed
the
dropped_chunk_fix
branch
from
b4a1dce
to
10b0bc1
Compare
- Since the actual tuple can simply be generated anyway through the layout rule chunks stack that is being produced. - Also avoids that bug fixed previously as duplicate data structures is simply dumb.
metatoaster
force-pushed
the
dropped_chunk_fix
branch
from
10b0bc1
to
8df4ce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a dumb accounting mistake with merging/combining of layout chunk rules on matched layouts, as previously two different lists were used for the tracking and a single offset generated from one was applied to both, however the accounting list will go out of sync (in length, thus offset) with the actual one that stores the rules to be applied, thus this will result in layouts chunks being dropped thus certain mismatched output will simply occur.
This set of changes provide a corrected accounting method to make use of just the actual complete layout rule chunk accounting stack, and provide an additional test to ensure that the produced output can still be parsed again.