Integrating calmjs-3 changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- More trove classifiers - Corrected comments.
metatoaster
force-pushed
the
calmjs.parse
branch
4 times, most recently
from
ff3de09
to
63fe156
Compare
metatoaster
force-pushed
the
calmjs.parse
branch
from
63fe156
to
6f709d2
Compare
metatoaster
force-pushed
the
calmjs.parse
branch
2 times, most recently
from
2cdf38f
to
d90cb40
Compare
metatoaster
force-pushed
the
calmjs.parse
branch
from
d90cb40
to
51419ba
Compare
- As calmjs upstream now provide certain walkers for getting the data, make use of those instead. - Remove the duplicated code. - Removing usage of slimit. - Bumping calmjs dependency - this does cause a test case failure due to error log not being empty due to deprecation. - Ensure unicode type is used in Python 2; process_path now takes an encoding parameter which defaults to utf-8.
metatoaster
force-pushed
the
calmjs.parse
branch
2 times, most recently
from
d02351b
to
82b8d9c
Compare
metatoaster
force-pushed
the
calmjs.parse
branch
2 times, most recently
from
203cdbf
to
3c0a868
Compare
- The runtime flags have not been changed yet. Will have to figure out a deprecation strategy at some point, due to source-map being not used correctly.
- Make it call calmjs.toolchain.spec_update_plugins_sourcepath_dict
- This will require some more work, as the text plugin still does not inject the bundle path yet. The workflow will need to be finalized.
- Ensure that the support is there for now.
- Text plugin (for requirejs) now has the package declaration - Also ensure that WORKING_DIR is added to the spec by the cli function - Have a toolchain test to ensure this is in working order
- As that is what the module is, and also to match with upstream. - The registry name should also be renamed, but the impact is not yet known. Will only be done if a deprecation mechanics is in place.
- Removed the compile_plugin method and related preparation steps, and converted it to make use of the generalized help functions that were moved to upstream.
- The mixin now inherits from BaseLoaderPluginHandler as that is the canonical class to do so - Other classes that previously inherited from that now inherit from the main implementation.
- Ensure that the usage of those hooks are done
- Only if possible. - Also given that the target will be cleaned in the fully defined circumstance, it no longer needs to strip the target for the target path.
- As bulk of the processing of loader plugins can be done using upstream methods, remove the custom handling code.
- Ensure that the intercepted condition return the expected types needed by the underlying call (provide the expected empty values).
metatoaster
force-pushed
the
calmjs.parse
branch
from
3c0a868
to
115e603
Compare
- Mostly to avoid overloading the term "source-map", and to be inline with calmjs.webpack.
metatoaster
force-pushed
the
calmjs.parse
branch
from
115e603
to
0085847
Compare
- Allow consistency and also removes the spurious warning when starting up.
metatoaster
force-pushed
the
calmjs.parse
branch
from
0085847
to
bf336af
Compare
- Define the relevant rules for the respective registries. - Only the complete artifact is supported at this time, however the definitions here serve as the starting point for dependents to figure out if they need more.
metatoaster
force-pushed
the
calmjs.parse
branch
6 times, most recently
from
fe9409a
to
a594df1
Compare
- Added basic artifact usage. - Adapted and merged in related documentation in calmjs.webpack - Corrected legacy wording in some logging output. - Removed the last removable vestige of slimit. Good riddance.
- pypy3 on travis is 3.5 now - just use pip with -U so that the latest correct version of setuptools will be used.
metatoaster
force-pushed
the
calmjs.parse
branch
from
fe9409a
to
c4cfdb1
Compare
- Ensure that calmjs.dev is not imported at the wrong level, which will fix this issue - Clean up the test harnesses a bit better.
- Seems like for a certain return type, the column is no longer included for some reason... so don't fail for things out of our control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the various updates to remove usage of deprecated identifiers, and to make use of calmjs.parse.