Force certain webpack loaders to resolve by aliased namespace/package #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This forces webpack to treat any resources resolved by loaderplugins through the standard modname also be available through a relative `./` prefixed path, as certain loaders implicitly make that lookup if the resource is included without any prefix. - This is in response to avoiding integrators of `calmjs.webpack` being forced to prefix their imports done within their non-JavaScript sources with webpack specific tokens which may be completely incompatible with standard systems (e.g. libsass).
metatoaster
force-pushed
the
loader_modname_alias
branch
from
86ddc0e
to
bedc502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the lack of the concept of namespaces or modules from within the environment, typical
webpackloaders will implicitly append a./, such that the resolution of'namespace/module'is turned into'./namespace/module'(which leads to the wrong location as the build directory is almost never the current directory), unless a~is prepended (i.e.'~namespace/module') to force the lookup. So to ensure that the calmjs system works as expected, also supply the./prefixed to the alias mapping as part of the standardBaseWebpackLoaderHandlerclass. For webpack loaders that fully respect theresolve.aliasmapping, it will enforce the correct behavior (tested withstyle-loaderandsass-loader).Reference: