detect observables properly when children are passed as part of props… #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… argument to createElement
Right now karet assumes that children are always passed in
React.createElement(type, props, [...children])
's argumentchildren
, however it is also possible that children are passed in the props object. For example if you takeprops
as an argument for a component and then spread that as a whole to another component:This will yield, when transpiled, in:
If children is just a single element, karet will actually work properly, but in case children is an array, like in this example, karet will fail to detect the observable in the array.
This PR addresses the issue.