refactor: the config should not be changeable after filled

calmonr · Sep 16, 2022 · a9fb427 · a9fb427
1 parent a3d9d4b
commit a9fb427
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/cmd/playground/app/config.go b/cmd/playground/app/config.go
@@ -8,8 +8,10 @@ type Config struct {
 	}
 }
 
-func (c *Config) Fill() {
+func (c Config) Fill() Config {
 	// grpc server
 	c.GRPCServer.Address = viper.GetString(PrefixGRPCServer + SuffixAddress)
 	c.GRPCServer.Network = viper.GetString(PrefixGRPCServer + SuffixNetwork)
+
+	return c
 }
diff --git a/cmd/playground/app/runnable/root.go b/cmd/playground/app/runnable/root.go
@@ -49,8 +49,7 @@ func NewRoot() command.Runnable {
 			}
 		}
 
-		cfg := new(app.Config)
-		cfg.Fill()
+		cfg := new(app.Config).Fill()
 
 		listener, err := net.Listen(cfg.GRPCServer.Network, cfg.GRPCServer.Address)
 		if err != nil {