Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expectations to at least pass integrations tests for dbt==0.20.0-b1 #59

Closed
clausherther opened this issue May 11, 2021 · 1 comment · Fixed by #82
Closed

Update expectations to at least pass integrations tests for dbt==0.20.0-b1 #59

clausherther opened this issue May 11, 2021 · 1 comment · Fixed by #82

Comments

@clausherther
Copy link
Contributor

We need to rewrite expectations to return failing rows, not counts
@clausherther clausherther mentioned this issue May 11, 2021
Closed
@jtcohen6
Copy link

jtcohen6 commented Jun 6, 2021

We just released 0.20.0rc1, and it includes a new config, fail_calc, that makes it possible to use calculations other than count(*) against failing rows. I think this will be important for backwards consistency with test queries that previously returned other numbers.

I took a look at #61, I can leave a few comments.

@clausherther clausherther linked a pull request Jun 8, 2021 that will close this issue
Update project for dbt 0.20.0 compatibility #82
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@clausherther @jtcohen6