expect_table_columns_to_match_ordered_list: refactor row_number to use loop.index #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clausherther
added a commit
that referenced
this pull request
Nov 10, 2021
* add `interval` argument for checking presence every n-date_parts instead of every date_part * update docs for explaining new `interval` arg [expect_row_values_to_have_data_for_every_n_datepart](https://github.com/calogica/dbt-expectations/tree/0.4.2#expect_row_values_to_have_data_for_every_n_datepart) * expect_table_columns_to_match_ordered_list: refactor row_number to use loop.index (#112) * Fixes #111 - refactor row_number to use loop.index * Update CHANGELOG * handle data types for `mod` and incorporate windowing This test will handle the mod function, which only takes integer arguments, more stably. It also aggregates row counts across intervals when joining on the date spine to correctly detect data presence in the target model update conditions based on interval update styling update styling * Add support for dbt 0.21 (#116) * Update README.md * remove unintentional styling changes * Fix expect_row_values_to_have_data_for_every_n_datepart errors when both start and end dates are set (#115) * fix none when both test dates are set * Add support for dbt 0.21 (#116) * Update README.md * fix none when both test dates are set * Update README Co-authored-by: Claus Herther <claus@calogica.com> * add `interval` argument for checking presence every n-date_parts instead of every date_part * update docs for explaining new `interval` arg [expect_row_values_to_have_data_for_every_n_datepart](https://github.com/calogica/dbt-expectations/tree/0.4.2#expect_row_values_to_have_data_for_every_n_datepart) * handle data types for `mod` and incorporate windowing This test will handle the mod function, which only takes integer arguments, more stably. It also aggregates row counts across intervals when joining on the date spine to correctly detect data presence in the target model update conditions based on interval update styling update styling * remove unintentional styling changes * Change datepart param and fix formatting * Reformat join to match prior style * simplify tie-out of model data to spine with interval truncation the condition added to the model_data CTE is meant to emulate (kind of) Snowflake's [`TIME_SLICE`](https://docs.snowflake.com/en/sql-reference/functions/time_slice.html), which should allow exact matches to the base_dates CTE for better time bucketing * Add schema test * replace calls to subquery with calls directly to columns in `model_data` CTE * add comments/examples for new interval additions Co-authored-by: Claus Herther <claus@calogica.com> Co-authored-by: Jeremy Yeo <jeremyyeo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111