Fix Redshift compatibility #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `expect_table_columns_to_match_ordered_list` macro is using column names as direct strings, which doesn't work on Redshift without an explicit cast to string. This cast was added previously and removed again in calogica@c698a1a#diff-14b201719d47d2b58e18a4896f8cb1d1f0bc3b414694499ef5eb738b683fb955L11-L12
clausherther
approved these changes
Nov 4, 2021
|
I'll cut a new release this weekend, possible pending another PR. Thanks for this quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
expect_table_columns_to_match_ordered_listmacro is using columnnames as direct strings, which doesn't work on Redshift without an
explicit cast to string.
This cast was added previously and removed again in
c698a1a#diff-14b201719d47d2b58e18a4896f8cb1d1f0bc3b414694499ef5eb738b683fb955L11-L12
Fixes #122
I have not tested this, just applied the previous fix.