Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #134

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Update README.md #134

merged 1 commit into from
Jan 3, 2022

Conversation

kdw2126
Copy link
Contributor

@kdw2126 kdw2126 commented Jan 3, 2022

This fixes the project's README.md file to remove group_by as a valid argument from these tests, since group_by isn't included as an argument for any of them:

  • expect_column_distinct_values_to_be_in_set
  • expect_column_distinct_values_to_contain_set
  • expect_column_distinct_values_to_equal_set

Closes #133.

clausherther
clausherther approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@clausherther clausherther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@clausherther
Copy link
Contributor

Thanks!!

@clausherther clausherther merged commit d843f2f into calogica:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clausherther clausherther clausherther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inaccurate Documentation for expect_column_distinct_values_to_[be_in/contain/equal]_set
2 participants
@kdw2126 @clausherther