Support a tree of scrollable elements #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpearce
reviewed
Feb 18, 2020
| parent = parent.parentNode; | ||
| } | ||
| parent = document.scrollingElement; | ||
| scrollableElements.push([parent, parent.scrollTop, parent.scrollLeft]); |
There was a problem hiding this comment.
FYI to anyone in the future that if document.scrollingElement doesn't exist, this will throw an error. Example would be in Internet Explorer or when testing with jest or anything that uses jsdom.
@calvellido As document.scrollingElement is document.documentElement by default (https://developer.mozilla.org/en-US/docs/Web/API/document/scrollingElement), would it make sense to fall back to documentElement when scrollingElement is not found?
parent = document.scrollingElement || document.documentElementFor jest users, place this in your test setup file:
document.scrollingElement = document.documentElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor based on what was proposed by @aFarkas in #3, traversing a tree of potential scrollable elements.
This closes #3