Fixes Edge bug with inputs and textareas

[kennethormandy]

I happened to see some inconsistent results with this polyfill on Edge v18.

• Edge does support the main test for this feature, but doesn’t prevent scrolling for text inputs and textareas.
• Edge fails this more recent web platform test that checks for that: https://wpt.live/html/interaction/focus/processing-model/preventScroll-textarea.html (note you have to scroll down, it looks like a blank page, but it isn’t)

I am doing some very light user agent checking to resolve this, which is obviously not ideal, but I couldn’t find another way to solve the problem since Edge does partially support focusOptions.

There’s also a tradeoff in that the polyfill is then used for everything, so you get a brief “flash” when the scrolling is prevented. That part is similar to what we saw on Safari, because it also needs the setTimeout.

Let me know what you think of this solution!

Without the polyfill

Doesn’t work the text inputs, but works natively on the button.

With the polyfill, and this fix

Works on both.

[calvellido]

Interesting! Thanks for the further review on Edge @kennethormandy! And also for adding the historic version of the Edge issue to the README 🙌.

Well, it's a sad thing that our friend Edge lies 😅. With that being the case, most probably there won't be any other option than to check for the UA. While everything is alright, if you are OK with it, I'm gonna leave the PR open to have a look at it at the weekend, where I'm gonna be able to explore this a bit more.

The flash bit is really tiring, but I'm not sure something additional could be done to prevent it 🤔. Also, it's probably more prone to happen on low-end devices, or bound to happen on computationally stressed instances, as I have had different results when testing.

Thanks again!

[kennethormandy]

While everything is alright, if you are OK with it, I'm gonna leave the PR open to have a look at it at the weekend, where I'm gonna be able to explore this a bit more.

Sure, feel free to take your time with it. I’ll use my fork as needed in the meantime. Thanks for the review.

[calvellido]

👍