forked from apache/beam
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BEAM-12769] Adds support for expanding a Java cross-language transfo…
…rm using the class name and builder methods (apache#15343) * Adds support for expanding a Java cross-language transform using the class name and builder methods * Adds an allowlist and adds support for annotations * Fix tests * Address CheckerFramework errors * Adds license * Addresses reviewer comments. * Apply suggestions from code review Co-authored-by: Lukasz Cwik <lcwik@google.com> * Addresses reviewer comments. * Updated the proto to include a single schema/payload for constructor and each builder method. Updated the implementation accordingly and added additional tests. * Some doc updates and few other minor updates. * Addressing reviewer comments Co-authored-by: Lukasz Cwik <lcwik@google.com>
- Loading branch information
1 parent
f2b9a13
commit e0d6332
Showing
10 changed files
with
1,941 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
...-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionServiceOptions.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.sdk.expansion.service; | ||
|
|
||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.dataformat.yaml.YAMLFactory; | ||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
| import org.apache.beam.sdk.expansion.service.JavaClassLookupTransformProvider.AllowList; | ||
| import org.apache.beam.sdk.options.Default; | ||
| import org.apache.beam.sdk.options.DefaultValueFactory; | ||
| import org.apache.beam.sdk.options.Description; | ||
| import org.apache.beam.sdk.options.PipelineOptions; | ||
|
|
||
| /** Options used to configure the {@link ExpansionService}. */ | ||
| public interface ExpansionServiceOptions extends PipelineOptions { | ||
|
|
||
| @Description("Allow list for Java class based transform expansion") | ||
| @Default.InstanceFactory(JavaClassLookupAllowListFactory.class) | ||
| AllowList getJavaClassLookupAllowlist(); | ||
|
|
||
| void setJavaClassLookupAllowlist(AllowList file); | ||
|
|
||
| @Description("Allow list file for Java class based transform expansion") | ||
| String getJavaClassLookupAllowlistFile(); | ||
|
|
||
| void setJavaClassLookupAllowlistFile(String file); | ||
|
|
||
| /** | ||
| * Loads the allow list from {@link #getJavaClassLookupAllowlistFile}, defaulting to an empty | ||
| * {@link JavaClassLookupTransformProvider.AllowList}. | ||
| */ | ||
| class JavaClassLookupAllowListFactory implements DefaultValueFactory<AllowList> { | ||
|
|
||
| @Override | ||
| public AllowList create(PipelineOptions options) { | ||
| String allowListFile = | ||
| options.as(ExpansionServiceOptions.class).getJavaClassLookupAllowlistFile(); | ||
| if (allowListFile != null) { | ||
| ObjectMapper mapper = new ObjectMapper(new YAMLFactory()); | ||
| File allowListFileObj = new File(allowListFile); | ||
| if (!allowListFileObj.exists()) { | ||
| throw new IllegalArgumentException( | ||
| "Allow list file " + allowListFile + " does not exist"); | ||
| } | ||
| try { | ||
| return mapper.readValue(allowListFileObj, AllowList.class); | ||
| } catch (IOException e) { | ||
| throw new IllegalArgumentException( | ||
| "Could not load the provided allowlist file " + allowListFile, e); | ||
| } | ||
| } | ||
|
|
||
| // By default produces an empty allow-list. | ||
| return new AutoValue_JavaClassLookupTransformProvider_AllowList( | ||
| JavaClassLookupTransformProvider.ALLOW_LIST_VERSION, new ArrayList<>()); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.