Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement oauth flow for Netatmo WeatherClient instead of requiring all secrets #78

Open
calvinmclean opened this issue Mar 5, 2023 · 1 comment
Labels
enhancement New feature or request server Related to the Go garden-app code

Comments

@calvinmclean
Copy link
Owner

calvinmclean commented Mar 5, 2023

Description

Instead of generating an access token and refresh token, you should be able to use the oauth flow to redirect to Netatmo website for login. This could be implemented as a CLI helper and/or as part of the process for creating a client using API.

@calvinmclean calvinmclean added enhancement New feature or request server Related to the Go garden-app code labels Mar 5, 2023
@calvinmclean
Copy link
Owner Author

This actually might not work well for my setup because OAuth would make sense for the case where there is a single server shared by multiple users, so the server would own a "Netatmo App" with client ID/secret and this would allow users to grant access to the server by logging-in with OAuth flow.

I should still be able to make it work by allowing POST client ID/secret to create a client, then this will initiate the OAuth flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server Related to the Go garden-app code
Projects
None yet
Development

No branches or pull requests

1 participant