Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create WeatherClient API resource and remove from config #77

Closed
9 of 11 tasks
calvinmclean opened this issue Mar 5, 2023 · 0 comments · Fixed by #86
Closed
9 of 11 tasks

Create WeatherClient API resource and remove from config #77

calvinmclean opened this issue Mar 5, 2023 · 0 comments · Fixed by #86
Labels
enhancement New feature or request server Related to the Go garden-app code

Comments

@calvinmclean
Copy link
Owner

calvinmclean commented Mar 5, 2023

Description

This feature is a pre-requisite to some other features related to WeatherClient because it will assign an ID to the client.

Related features:

Requirements

  • Use same format as the current configuration
  • Located on the root path of the API
  • Assign and ID and "display name" to the clients
  • Research and create issue for secure credential storage, but initial implementation will just store in YAML
  • This will not affect SoilMoistureControl because that is tied to a physical garden-controller and should only work with Zone's in a Garden with moisture sensors
  • Netatmo client should update and save access_token and refresh_token when using refresh token
  • Implementation details:
    • WeatherControl now needs to reference a WeatherClient's ID
    • Remove from config
    • Add yaml and json tags to structs
    • Implement in CRUD in StorageClient
    • Add API CRUD endpoints
    • Add Validate method to WeatherClient so Options can be validated for specific clients create endpoint will initialize the client which should verify if it is valid
    • Add /test endpoint or something similar to test weather client configuration/auth
    • Add configmap storage client
    • OpenAPI specification and docs
    • testing
@calvinmclean calvinmclean added enhancement New feature or request server Related to the Go garden-app code labels Mar 5, 2023
calvinmclean added a commit that referenced this issue Apr 2, 2023
- Updated types and interfaces
- Added to part of weather control

Still TODO:
  - implement storage clients
  - implement API
  - update tests

Closes #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server Related to the Go garden-app code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant