Add temperature-based water scaling #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinmclean
force-pushed
the
feature/19/weather-scaling
branch
4 times, most recently
from
2378361
to
3e1024c
Compare
|
Remaining TODO:
|
calvinmclean
force-pushed
the
feature/19/weather-scaling
branch
6 times, most recently
from
65300ce
to
14af89b
Compare
- Scale WaterSchedule.Duration up/down based on recent average high temperatures and configured parameters - Improve Netatmo WeatherClient - Remove FakeClient because mock is better Closes #19
calvinmclean
force-pushed
the
feature/19/weather-scaling
branch
from
14af89b
to
bab5978
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19