Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use of EndDateable for GetAll filtering #63

Merged
merged 2 commits into from
May 2, 2024

Conversation

calvinmclean
Copy link
Owner

No description provided.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.97%. Comparing base (66c4fb2) to head (e6e0013).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   82.22%   81.97%   -0.25%     
==========================================
  Files          20       22       +2     
  Lines        1384     1426      +42     
==========================================
+ Hits         1138     1169      +31     
- Misses        158      164       +6     
- Partials       88       93       +5     

- This avoids having duplicated implementations of in-memory storage
- Also fixes the issue with pointers being stored in a map and being
  externally mutable
- Makes things more consistent if switching to Hord storage later on
@calvinmclean calvinmclean merged commit afa42ab into main May 2, 2024
5 checks passed
@calvinmclean calvinmclean deleted the feature/improve-end-date-kv branch May 2, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant