-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-u option does not work #6
Comments
Still broken :S |
My changes never made it to the main code line |
sorry I never responded, could you open a pull ? |
Is there any update on this? |
My changes were lost long before this conversation reopened, sorry. |
too old to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Calvin,
apologies for the confusion: I was somewhat convinced the isFile() filtering will fix the -u issue too. It turned out it is not. The 4 test cases with -u are still failing for me.
I have committed the a version to my clone that I believe fixes the issue (the path.normalize call we've been going back and forth) and some logging that helps further diagnostics in the future. I hope you will find it useful.
Let me know if you need a pull request from my end.
The text was updated successfully, but these errors were encountered: