Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cert uploading issues #141

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

lil131
Copy link
Collaborator

@lil131 lil131 commented Aug 4, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@lil131
Copy link
Collaborator Author

lil131 commented Aug 4, 2022

  1. fixing the reported issue: Certificate upload fails via cli but works via portal
  2. fixing the bug where replacing invalid characters in cert names failed
  3. removing the test case for .pem cert uploading for now, as the api doesn't support .pem certs yet, and a private key validation was added to the api recently which will lead to the "Certificate must contain one private key." error for .pem certs.

Copy link
Collaborator

@StrawnSC StrawnSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a small merge conflict that needs to be fixed before we can merge

@StrawnSC
Copy link
Collaborator

Also, @lil131 can you link the GitHub issue(s) that are related to this fix?

@lil131 lil131 requested a review from StrawnSC August 10, 2022 18:37
@lil131 lil131 merged commit ed5d5ba into calvinsID:containerapp-0.3.9 Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants