-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new Microsoft.Graph API for service principals #85
Commits on Apr 7, 2022
-
Marchp1s and add back Identity (#57)
* Skeleton code * az containerapp env show * List kube/managed environments * Create kube environment, wait doesn't work yet * Update containerapp stubs (check if it is supported now) * Containerapp env delete, polling not working yet * Added polling for create and delete * Use Microsoft.App RP for show, list, delete command * Create containerapp env using Microsoft.App RP * Add optional containerapp env create arguments * Remove old kube environment code, naming fixes * Containerapp create almost done * Done containerapp create, except for --yaml. Need to test * Containerapp show, list * Fix helptext * Containerapp delete * Containerapp update. Needs secrets api to be implemented, and testing * Add scale command * Various validations, small fixes * listSecrets API for updates, autogen log analytics for env * Use space delimiter for secrets and env variables * Verify sub is registered to Microsoft.ContainerRegistration if creating vnet enabled env, remove logs-type parameter * Containerapp create --yaml * Fix updating registry to do create or update * Fix containerapp update command. Add image-name parameter to support multi container updates. Fix updating registries, containers and secrets * started update with --yaml. Need to do create or update for when an attribute is a list of items * use space delimiter for startup_command and args, instead of comma delimiter * Traffic weights * List and show revisions * az containerapp revision restart, activate, deactivate * Add ability for users to clear args/command in az containerapp update * Various fixes, traffic weights fixes * Verify subnet subscription is registered to Microsoft.ContainerServices * GitHub Actions Update (Azure#17) * Added models. Finished transferring Calvin's previous work. * Updated wrong models. * Updated models in custom.py, added githubactionclient. * Updated envelope to be correct. * Small bug fixes. * Updated error handling. Fixed bugs. Initial working state. * Added better error handling. * Added error messages for tokens with inappropriate access rights. * Added back get_acr_cred. * Fixed problems from merge conflict. * Updated names of imports from ._models.py to fix pylance erros. * Removed random imports. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Remove --location since location must be same as managed env * Add options for flag names: --env-vars and --registry-srever * Empty string to clear env_vars * Default revisions_mode to single * Infer acr credentials if it is acr and credentials are not provided * fix help msg * if image is hosted on acr, and no registry server is supplied, infer the registry server * Added subgroups (Ingress, Registry, Secret) and updated revisions (Azure#18) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Modified update_containerapp_yaml to support updating from non-current revision. Authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * More p0 fixes (Azure#20) * Remove --registry-login-server, only allow --registry-server * Rename --environment-variables to --env-vars * If no image is supplied, use default quickstart image * Update help text (Azure#21) * Update help text * Update punctuation * master -> main * New 1.0.1 version * Added identity commands + --assign-identity flag to containerapp create (#8) * Added identity show and assign. * Finisheed identity remove. * Added helps, updated identity remove to work with identity names instead of requiring identity resource ids. * Moved helper function to utils. * Require --identities flag when removing identities. * Added message for assign identity with no specified identity. * Added --assign-identity flag to containerapp create. * Moved assign-identity flag to containerapp create. * Fixed small logic error on remove identities when passing duplicate identities. Added warnings for certain edge cases. * Updated param definition for identity assign --identity default. * Added identity examples in help. * Made sure secrets were not removed when assigning identities. Added tolerance for [system] passed with capital letters. * Fixed error from merge. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Dapr Commands (Azure#23) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Added dapr enable and dapr disable. Need to test more. * Added list, show, set dapr component. Added dapr enable, disable. * Added delete dapr delete. * Added helps and param text. * Changed dapr delete to dapr remove to match with dapr set. * Commented out managed identity for whl file. * Uncommented. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Rename --image-name to --container-name * Remove allowInsecure since it was messing with the api parsing * Fix for env var being empty string * Rename to --dapr-instrumentation-key, only infer ACR credentials if --registry-server is provided * Remove az containerapp scale * Fix delete containerapp errors * Remove ingress, dapr flags from az containerapp update/revision copy * Fix revision list -o table * Help text fix * Bump extension to 0.1.2 * Update managed identities and Dapr help text (Azure#25) * Update managed identities and Dapr help text * Update Dapr flags * Add secretref note * Env var options + various bug fixes (Azure#26) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Fixed style issues, various bug fixes (Azure#27) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_scenario.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * Specific Error Types + Bugfixes (Help, remove app-subnet-resource-id, removed env-var alias, added help text for --name) (Azure#28) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. * Update helps for identity, revision. Removed env-var alias for set-env-vars. Added name param help. * Removed app-subnet-resource-id. * Updated infrastructure subnet param help. * Check if containerapp resource exists before attempting to delete. * Added check before deleting managed env. * Changed error types to be more specific. * Removed check before deletion. Removed comments. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Reset to 0.1.0 version, remove unneeded options-list * Update min cli core version * Fixed style issues. (Azure#30) Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Fix linter issues * Use custom-show-command * Removed --ids from revision, secret, registry list. * Add linter exclusions * Fix polling on delete containerapp * Fix error handling * Add Container App Service * Fix flake linter * Fix help text * Mark extension as preview * Add python 3.9 and 3.10 as supported * Remove registries and secrets from az containerapp update, in favor of registry and secret subgroup * Fix YAML not working * Move import to inside deserialize function * Ingress enable --transport default. Secret list returns empty array. Secret update prints message saying user needs to restart their apps. Added show-values flag to secret list. Fixed yaml datetime field issues, replaced x00 values that also came up during testing. * Fixed dapr in create. * Revert "Ingress enable --transport default. Secret list returns empty array. Secret update prints message saying user needs to restart their apps. Added show-values flag to secret list. Fixed yaml datetime field issues, replaced x00 values that also came up during testing." This reverts commit 51bc543. * Revert "Fixed dapr in create." This reverts commit 37030ad. * Ingress enable --transport default. Secret list returns empty array. Secret update prints message saying user needs to restart their apps. Added show-values flag to secret list. Fixed yaml datetime field issues, replaced x00 values that also came up during testing. * Skeleton code * az containerapp env show * List kube/managed environments * Create kube environment, wait doesn't work yet * Update containerapp stubs (check if it is supported now) * Containerapp env delete, polling not working yet * Added polling for create and delete * Use Microsoft.App RP for show, list, delete command * Create containerapp env using Microsoft.App RP * Add optional containerapp env create arguments * Remove old kube environment code, naming fixes * Containerapp create almost done * Done containerapp create, except for --yaml. Need to test * Containerapp show, list * Fix helptext * Containerapp delete * Containerapp update. Needs secrets api to be implemented, and testing * Add scale command * Various validations, small fixes * listSecrets API for updates, autogen log analytics for env * Use space delimiter for secrets and env variables * Verify sub is registered to Microsoft.ContainerRegistration if creating vnet enabled env, remove logs-type parameter * Containerapp create --yaml * Fix updating registry to do create or update * Fix containerapp update command. Add image-name parameter to support multi container updates. Fix updating registries, containers and secrets * started update with --yaml. Need to do create or update for when an attribute is a list of items * use space delimiter for startup_command and args, instead of comma delimiter * Traffic weights * List and show revisions * az containerapp revision restart, activate, deactivate * Add ability for users to clear args/command in az containerapp update * Various fixes, traffic weights fixes * Verify subnet subscription is registered to Microsoft.ContainerServices * GitHub Actions Update (Azure#17) * Added models. Finished transferring Calvin's previous work. * Updated wrong models. * Updated models in custom.py, added githubactionclient. * Updated envelope to be correct. * Small bug fixes. * Updated error handling. Fixed bugs. Initial working state. * Added better error handling. * Added error messages for tokens with inappropriate access rights. * Added back get_acr_cred. * Fixed problems from merge conflict. * Updated names of imports from ._models.py to fix pylance erros. * Removed random imports. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Remove --location since location must be same as managed env * Add options for flag names: --env-vars and --registry-srever * Empty string to clear env_vars * Default revisions_mode to single * Infer acr credentials if it is acr and credentials are not provided * fix help msg * if image is hosted on acr, and no registry server is supplied, infer the registry server * Added subgroups (Ingress, Registry, Secret) and updated revisions (Azure#18) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Modified update_containerapp_yaml to support updating from non-current revision. Authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * More p0 fixes (Azure#20) * Remove --registry-login-server, only allow --registry-server * Rename --environment-variables to --env-vars * If no image is supplied, use default quickstart image * Update help text (Azure#21) * Update help text * Update punctuation * master -> main * New 1.0.1 version * Added identity commands + --assign-identity flag to containerapp create (#8) * Added identity show and assign. * Finisheed identity remove. * Added helps, updated identity remove to work with identity names instead of requiring identity resource ids. * Moved helper function to utils. * Require --identities flag when removing identities. * Added message for assign identity with no specified identity. * Added --assign-identity flag to containerapp create. * Moved assign-identity flag to containerapp create. * Fixed small logic error on remove identities when passing duplicate identities. Added warnings for certain edge cases. * Updated param definition for identity assign --identity default. * Added identity examples in help. * Made sure secrets were not removed when assigning identities. Added tolerance for [system] passed with capital letters. * Fixed error from merge. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Dapr Commands (Azure#23) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Added dapr enable and dapr disable. Need to test more. * Added list, show, set dapr component. Added dapr enable, disable. * Added delete dapr delete. * Added helps and param text. * Changed dapr delete to dapr remove to match with dapr set. * Commented out managed identity for whl file. * Uncommented. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Rename --image-name to --container-name * Remove allowInsecure since it was messing with the api parsing * Fix for env var being empty string * Rename to --dapr-instrumentation-key, only infer ACR credentials if --registry-server is provided * Remove az containerapp scale * Fix delete containerapp errors * Remove ingress, dapr flags from az containerapp update/revision copy * Fix revision list -o table * Help text fix * Bump extension to 0.1.2 * Update managed identities and Dapr help text (Azure#25) * Update managed identities and Dapr help text * Update Dapr flags * Add secretref note * Env var options + various bug fixes (Azure#26) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Fixed style issues, various bug fixes (Azure#27) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_scenario.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * Specific Error Types + Bugfixes (Help, remove app-subnet-resource-id, removed env-var alias, added help text for --name) (Azure#28) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. * Update helps for identity, revision. Removed env-var alias for set-env-vars. Added name param help. * Removed app-subnet-resource-id. * Updated infrastructure subnet param help. * Check if containerapp resource exists before attempting to delete. * Added check before deleting managed env. * Changed error types to be more specific. * Removed check before deletion. Removed comments. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Reset to 0.1.0 version, remove unneeded options-list * Update min cli core version * Fixed style issues. (Azure#30) Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Fix linter issues * Use custom-show-command * Removed --ids from revision, secret, registry list. * Add linter exclusions * Fix polling on delete containerapp * Fix error handling * Add Container App Service * Fix flake linter * Fix help text * Mark extension as preview * Add python 3.9 and 3.10 as supported * Remove registries and secrets from az containerapp update, in favor of registry and secret subgroup * Fix YAML not working * Move import to inside deserialize function * Dapr moved from Template to Configuration * Use aka.ms link for containerapps yaml * Updated dapr enable/disable to current spec. * Fixed oversight. * Remove revisions-mode from containerapp update * Fixed dapr enable property names. (Azure#47) Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Fix exceptions with using --yaml in containerapp create/update * Rename history msg * Include fqdn in containerapp table output * Added ingress messages. * Revert history msg * Reduced redundant code between revision copy and containerapp update. * Fixed merge issues. * Fixed merge conflicts, moved helper function Co-authored-by: Calvin Chan <calvinch4n@gmail.com> Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> Co-authored-by: Anthony Chu <anthony@anthonychu.ca> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 1de51ee - Browse repository at this point
Copy the full SHA 1de51eeView commit details
Commits on Apr 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7735595 - Browse repository at this point
Copy the full SHA 7735595View commit details
Commits on Apr 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2e1be89 - Browse repository at this point
Copy the full SHA 2e1be89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fcd785 - Browse repository at this point
Copy the full SHA 5fcd785View commit details -
Updated managed identity + help. (Azure#61)
Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for a1929c8 - Browse repository at this point
Copy the full SHA a1929c8View commit details -
Added user-assigned and system-assigned to containerapp create. (Azur…
…e#62) Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for df5cc99 - Browse repository at this point
Copy the full SHA df5cc99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dedf19 - Browse repository at this point
Copy the full SHA 0dedf19View commit details -
Added more specific MSI help text. (Azure#64)
* Added more specific MSI help text. * Updated help text. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 1474d69 - Browse repository at this point
Copy the full SHA 1474d69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5afc2b1 - Browse repository at this point
Copy the full SHA 5afc2b1View commit details
Commits on Apr 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 77dcaa0 - Browse repository at this point
Copy the full SHA 77dcaa0View commit details
Commits on Apr 15, 2022
-
Container App Test suite (Azure#67)
* Add tests for containerapp create * All tests under the same function to share environment - need to figure how to get multiple functions to share environment * Basic tests
Configuration menu - View commit details
-
Copy full SHA for 5cc0aa8 - Browse repository at this point
Copy the full SHA 5cc0aa8View commit details
Commits on Apr 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1f1b31a - Browse repository at this point
Copy the full SHA 1f1b31aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f70e2f - Browse repository at this point
Copy the full SHA 7f70e2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa539a8 - Browse repository at this point
Copy the full SHA fa539a8View commit details
Commits on Apr 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f935df8 - Browse repository at this point
Copy the full SHA f935df8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7da2e9a - Browse repository at this point
Copy the full SHA 7da2e9aView commit details -
Managed Identity Tests (Azure#69)
* Added managed identity tests. * Fixed msi tests. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for fcc3d87 - Browse repository at this point
Copy the full SHA fcc3d87View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb6820e - Browse repository at this point
Copy the full SHA cb6820eView commit details -
Managed Identity Fixes (Azure#71)
* Added managed identity tests. * Fixed msi tests. * Added live_only to managed identity tests. * Changed region to eastus2 from canary. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for f6efbd2 - Browse repository at this point
Copy the full SHA f6efbd2View commit details
Commits on Apr 19, 2022
-
Update src/containerapp/azext_containerapp/_params.py
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 4e805bf - Browse repository at this point
Copy the full SHA 4e805bfView commit details
Commits on Apr 22, 2022
-
4/26 release: Up with --repo/--browse, exec (ssh) command, replica co…
…mmands, log streaming commands (Azure#72) * Skeleton code * az containerapp env show * List kube/managed environments * Create kube environment, wait doesn't work yet * Update containerapp stubs (check if it is supported now) * Containerapp env delete, polling not working yet * Added polling for create and delete * Use Microsoft.App RP for show, list, delete command * Create containerapp env using Microsoft.App RP * Add optional containerapp env create arguments * Remove old kube environment code, naming fixes * Containerapp create almost done * Done containerapp create, except for --yaml. Need to test * Containerapp show, list * Fix helptext * Containerapp delete * Containerapp update. Needs secrets api to be implemented, and testing * Add scale command * Various validations, small fixes * listSecrets API for updates, autogen log analytics for env * Use space delimiter for secrets and env variables * Verify sub is registered to Microsoft.ContainerRegistration if creating vnet enabled env, remove logs-type parameter * Containerapp create --yaml * Fix updating registry to do create or update * Fix containerapp update command. Add image-name parameter to support multi container updates. Fix updating registries, containers and secrets * started update with --yaml. Need to do create or update for when an attribute is a list of items * use space delimiter for startup_command and args, instead of comma delimiter * Traffic weights * List and show revisions * az containerapp revision restart, activate, deactivate * Add ability for users to clear args/command in az containerapp update * Various fixes, traffic weights fixes * Verify subnet subscription is registered to Microsoft.ContainerServices * GitHub Actions Update (Azure#17) * Added models. Finished transferring Calvin's previous work. * Updated wrong models. * Updated models in custom.py, added githubactionclient. * Updated envelope to be correct. * Small bug fixes. * Updated error handling. Fixed bugs. Initial working state. * Added better error handling. * Added error messages for tokens with inappropriate access rights. * Added back get_acr_cred. * Fixed problems from merge conflict. * Updated names of imports from ._models.py to fix pylance erros. * Removed random imports. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Remove --location since location must be same as managed env * Add options for flag names: --env-vars and --registry-srever * Empty string to clear env_vars * Default revisions_mode to single * Infer acr credentials if it is acr and credentials are not provided * fix help msg * if image is hosted on acr, and no registry server is supplied, infer the registry server * Added subgroups (Ingress, Registry, Secret) and updated revisions (Azure#18) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Modified update_containerapp_yaml to support updating from non-current revision. Authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * More p0 fixes (Azure#20) * Remove --registry-login-server, only allow --registry-server * Rename --environment-variables to --env-vars * If no image is supplied, use default quickstart image * Update help text (Azure#21) * Update help text * Update punctuation * master -> main * New 1.0.1 version * Added identity commands + --assign-identity flag to containerapp create (#8) * Added identity show and assign. * Finisheed identity remove. * Added helps, updated identity remove to work with identity names instead of requiring identity resource ids. * Moved helper function to utils. * Require --identities flag when removing identities. * Added message for assign identity with no specified identity. * Added --assign-identity flag to containerapp create. * Moved assign-identity flag to containerapp create. * Fixed small logic error on remove identities when passing duplicate identities. Added warnings for certain edge cases. * Updated param definition for identity assign --identity default. * Added identity examples in help. * Made sure secrets were not removed when assigning identities. Added tolerance for [system] passed with capital letters. * Fixed error from merge. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Dapr Commands (Azure#23) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Added dapr enable and dapr disable. Need to test more. * Added list, show, set dapr component. Added dapr enable, disable. * Added delete dapr delete. * Added helps and param text. * Changed dapr delete to dapr remove to match with dapr set. * Commented out managed identity for whl file. * Uncommented. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Rename --image-name to --container-name * Remove allowInsecure since it was messing with the api parsing * Fix for env var being empty string * Rename to --dapr-instrumentation-key, only infer ACR credentials if --registry-server is provided * Remove az containerapp scale * Fix delete containerapp errors * Remove ingress, dapr flags from az containerapp update/revision copy * Fix revision list -o table * Help text fix * Bump extension to 0.1.2 * Update managed identities and Dapr help text (Azure#25) * Update managed identities and Dapr help text * Update Dapr flags * Add secretref note * Env var options + various bug fixes (Azure#26) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Fixed style issues, various bug fixes (Azure#27) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_scenario.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * Specific Error Types + Bugfixes (Help, remove app-subnet-resource-id, removed env-var alias, added help text for --name) (Azure#28) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. * Update helps for identity, revision. Removed env-var alias for set-env-vars. Added name param help. * Removed app-subnet-resource-id. * Updated infrastructure subnet param help. * Check if containerapp resource exists before attempting to delete. * Added check before deleting managed env. * Changed error types to be more specific. * Removed check before deletion. Removed comments. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Reset to 0.1.0 version, remove unneeded options-list * Update min cli core version * Fixed style issues. (Azure#30) Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Fix linter issues * Use custom-show-command * Removed --ids from revision, secret, registry list. * Add linter exclusions * Fix polling on delete containerapp * Fix error handling * Add Container App Service * Fix flake linter * Fix help text * Mark extension as preview * Add python 3.9 and 3.10 as supported * Remove registries and secrets from az containerapp update, in favor of registry and secret subgroup * Fix YAML not working * Move import to inside deserialize function * Dapr moved from Template to Configuration * Use aka.ms link for containerapps yaml * Updated dapr enable/disable to current spec. * Fixed oversight. * Remove revisions-mode from containerapp update * Fixed dapr enable property names. (Azure#47) Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> * Fix exceptions with using --yaml in containerapp create/update * Rename history msg * Include fqdn in containerapp table output * Added ingress messages. * Revert history msg * Add basic test case * Remove managed-identity support for first release of CLI * Need to investigate test flakiness * Update _help.py removing duplicate help * Added prototype of container up. * Fixed deploy from acr registry image infer credentials issue. * Tried to add source. * Added acr build. * Finished acr build functionality. * Added acr create functionality and pull registry from existing containerapp if it exists. * Fixed bugs. * Check if rg exists and create one with name if it doesn't. * initial containerapp ssh implementation * fix interactive commands (vim); handle ctrl + c instead of exiting * fix style and linter issues * Added disable verbose. Moved utils into utils.py. * fix for ssh for windows clients * fix for unix * Disable verbose now uses sdk poller so it gives running animation. * Added helps for params. Added error handling for non acr registry passed with source. Ignore param disable_warnings for create and no_wait for up. * Updated disable_warnings ignore. Removed disable_warnings from update_containerapp. * add terminal resizing * reorganize code; implement terminal resizing, add startup command param, etc * organize code, remove token from warning output * add validations, add replica commands * use the correct API for fetching default container; remove is_preview * Renamed silent to quiet. * Fixed style issues. * add log streaming, bump version number and add to HISTORY.rst * add basic ssh test * Added workspace name and fqdn to dry_run_str. Added indicators of if the resources are new or existing to dry_run_str. * fix ssh test for windows * Check RP for location when not provided. Open Dockerfile and use EXPOSE for CA port. * fix windows arrow keys after exit * fix typo, add logstream test, remove token from logstream output * Removed print statement. * Updated dockerfile expose automatic ingress feature. * Removed dry run str, added dry run obj instead. * use bearer auth; fix --command bug * add handling for smooth transition to new URL path * Fixed merge conflict. * fix merge conflicts * Create env if name passed and it doesn't exist. * Added missing import from merge. * Added prototype for new environment workflow. * Finished environment logic. * Minor updates before demo. * add 'az containerapp github up' (wip) * various fixes for demo * rearrange github up code * merge haroonf/containerappup * start up refactor * add --repo to up and refactor up * reorganize code more; fix various bugs * fix linter issues, fix lingering exec/tail improvements * update history * update output * bug fixes for --repo * fix --source bug * fix --source * minor bug fixes * Added API change. * Finished API change, added helloworld image auto ingress, checked provisioning state beforehand. * fixes for sisira's comments * fix minor typo * bug fix where commands fail if providing registry creds * Fixed style issues. * Updated help and version text. Co-authored-by: Calvin Chan <calvinch4n@gmail.com> Co-authored-by: Haroon Feisal <38823870+haroonf@users.noreply.github.com> Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> Co-authored-by: Anthony Chu <anthony@anthonychu.ca> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> Co-authored-by: Sisira Panchagnula <panchagnula@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7f7f1fe - Browse repository at this point
Copy the full SHA 7f7f1feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d794b3 - Browse repository at this point
Copy the full SHA 3d794b3View commit details -
Haroon Feisal committed
Apr 22, 2022 Configuration menu - View commit details
-
Copy full SHA for e87accc - Browse repository at this point
Copy the full SHA e87acccView commit details
Commits on Apr 25, 2022
-
Removed flake exclusions and removed type=str from params.
Haroon Feisal committedApr 25, 2022 Configuration menu - View commit details
-
Copy full SHA for 552850f - Browse repository at this point
Copy the full SHA 552850fView commit details -
Fixed repo bug when searching for dockerfile, increased timeout on gi…
…thub action complete, fixed datetime import issue from style fix.
Haroon Feisal committedApr 25, 2022 Configuration menu - View commit details
-
Copy full SHA for b86d217 - Browse repository at this point
Copy the full SHA b86d217View commit details -
Haroon Feisal committed
Apr 25, 2022 Configuration menu - View commit details
-
Copy full SHA for 31002f8 - Browse repository at this point
Copy the full SHA 31002f8View commit details -
Assume port if ingress is provided with image and port is not.
Haroon Feisal committedApr 25, 2022 Configuration menu - View commit details
-
Copy full SHA for c292ac9 - Browse repository at this point
Copy the full SHA c292ac9View commit details -
Haroon Feisal committed
Apr 25, 2022 Configuration menu - View commit details
-
Copy full SHA for b9fce25 - Browse repository at this point
Copy the full SHA b9fce25View commit details -
Haroon Feisal committed
Apr 25, 2022 Configuration menu - View commit details
-
Copy full SHA for 077bf20 - Browse repository at this point
Copy the full SHA 077bf20View commit details
Commits on Apr 26, 2022
-
Search for acr before creating one.
Haroon Feisal committedApr 26, 2022 Configuration menu - View commit details
-
Copy full SHA for c100f1f - Browse repository at this point
Copy the full SHA c100f1fView commit details -
Fixed bug where only --environment is passed. Changed hash on acr nam…
…e to make it more unique. Tiny change in find_existing_acr.
Haroon Feisal committedApr 26, 2022 Configuration menu - View commit details
-
Copy full SHA for 44faaf7 - Browse repository at this point
Copy the full SHA 44faaf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 197913a - Browse repository at this point
Copy the full SHA 197913aView commit details -
Fixed bug with --image. Changed logger warning output. Disabled warni…
…ngs on the registry update code for containerapp up. Added HELLOWORLD constant.
Haroon Feisal committedApr 26, 2022 Configuration menu - View commit details
-
Copy full SHA for 595cdf5 - Browse repository at this point
Copy the full SHA 595cdf5View commit details -
Disabled no_wait. Added better error handling for up API calls. Updat…
…ed ingress infer warning text. Fixed typo. Moved create_if_needed to environment.
Haroon Feisal committedApr 26, 2022 Configuration menu - View commit details
-
Copy full SHA for 272146b - Browse repository at this point
Copy the full SHA 272146bView commit details -
fix ACR length cap; enforce name/secret limits; trigger GH action if …
…needed (update with GH actions already extant); fail command if GH action ends in failure
Configuration menu - View commit details
-
Copy full SHA for 988d901 - Browse repository at this point
Copy the full SHA 988d901View commit details -
Configuration menu - View commit details
-
Copy full SHA for e935bf2 - Browse repository at this point
Copy the full SHA e935bf2View commit details -
Merge pull request Azure#77 from haroonf/findacr2
ACR changes + bug fixes
Configuration menu - View commit details
-
Copy full SHA for 50617e1 - Browse repository at this point
Copy the full SHA 50617e1View commit details
Commits on Apr 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 757dcf4 - Browse repository at this point
Copy the full SHA 757dcf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbeac7a - Browse repository at this point
Copy the full SHA cbeac7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44aa7ff - Browse repository at this point
Copy the full SHA 44aa7ffView commit details -
Fixed --registry-server with --image bug. (Azure#78)
* Fixed --registry-server with --image bug. * Fixed style issues. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for a016f35 - Browse repository at this point
Copy the full SHA a016f35View commit details -
Configuration menu - View commit details
-
Copy full SHA for c59d257 - Browse repository at this point
Copy the full SHA c59d257View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd2cc8b - Browse repository at this point
Copy the full SHA bd2cc8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b58d27 - Browse repository at this point
Copy the full SHA 2b58d27View commit details -
Added prototype for env check.
Haroon Feisal committedApr 27, 2022 Configuration menu - View commit details
-
Copy full SHA for 668b7d9 - Browse repository at this point
Copy the full SHA 668b7d9View commit details -
Honor location and environment passed to create new containerapp (eve…
…n if a CA exists on subscription with the same name) (Azure#79) * Create new Containerapp if user passes env name even if a CA exists with the same name. * Create a new app if location doesn't match any other app. * Fixed small bug, added better error handling for multiple environments with the same name on subscription. Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 25843f1 - Browse repository at this point
Copy the full SHA 25843f1View commit details -
print created SP name/id; prevent using ACR names longer than 20 char…
…s with --repo; add basic --image test
Configuration menu - View commit details
-
Copy full SHA for 612d1a5 - Browse repository at this point
Copy the full SHA 612d1a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 900e7b6 - Browse repository at this point
Copy the full SHA 900e7b6View commit details
Commits on Apr 28, 2022
-
Haroon Feisal committed
Apr 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 6710636 - Browse repository at this point
Copy the full SHA 6710636View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50e0754 - Browse repository at this point
Copy the full SHA 50e0754View commit details -
Configuration menu - View commit details
-
Copy full SHA for d53550b - Browse repository at this point
Copy the full SHA d53550bView commit details -
Haroon Feisal committed
Apr 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 66878c7 - Browse repository at this point
Copy the full SHA 66878c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37627de - Browse repository at this point
Copy the full SHA 37627deView commit details
Commits on Apr 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5f5308e - Browse repository at this point
Copy the full SHA 5f5308eView commit details -
Added error message with eligible locations if users pass uneligible …
…location.
Haroon Feisal committedApr 29, 2022 Configuration menu - View commit details
-
Copy full SHA for 7b0bd7d - Browse repository at this point
Copy the full SHA 7b0bd7dView commit details -
Added function to check if env already exists so we don't try to upda…
…te the location value of an existing environment.
Haroon Feisal committedApr 29, 2022 Configuration menu - View commit details
-
Copy full SHA for c534455 - Browse repository at this point
Copy the full SHA c534455View commit details -
Added error handling for location northcentralusstage. Added list of …
…eligible locations to unallowed location error message.
Haroon Feisal committedApr 29, 2022 Configuration menu - View commit details
-
Copy full SHA for 3e576de - Browse repository at this point
Copy the full SHA 3e576deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 724249a - Browse repository at this point
Copy the full SHA 724249aView commit details -
Small fixes, implemented check_env_name_on_rg.
Haroon Feisal committedApr 29, 2022 Configuration menu - View commit details
-
Copy full SHA for a1ce4dd - Browse repository at this point
Copy the full SHA a1ce4ddView commit details
Commits on May 2, 2022
-
Merge pull request Azure#80 from haroonf/managedenvcheck
Check location of managed environment before attempting to create
Configuration menu - View commit details
-
Copy full SHA for 4fc7267 - Browse repository at this point
Copy the full SHA 4fc7267View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8a6ac1 - Browse repository at this point
Copy the full SHA a8a6ac1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5570ad9 - Browse repository at this point
Copy the full SHA 5570ad9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ccbce0 - Browse repository at this point
Copy the full SHA 2ccbce0View commit details
Commits on May 3, 2022
-
* Updates to update tests * Update api version for create
Configuration menu - View commit details
-
Copy full SHA for 34aabca - Browse repository at this point
Copy the full SHA 34aabcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b3468a - Browse repository at this point
Copy the full SHA 6b3468aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53ddc45 - Browse repository at this point
Copy the full SHA 53ddc45View commit details
Commits on May 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 398d4c7 - Browse repository at this point
Copy the full SHA 398d4c7View commit details