[Cider 2] Misc fixes + fud2 integration #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahanxie353
pushed a commit
to jiahanxie353/calyx
that referenced
this pull request
May 29, 2024
* Refactor program counter to avoid `std::mem::take` * add a helper method * Refactor code to use `lookup_string` method for retrieving names in the environment * Refactor code to use `lookup_string` method for retrieving names in the environment * Minor tweak * stab at fud2 integration * bump MSRVs to make clippy stop bugging me * my life is a never ending litany of suffering * snapshotsssss * more snappéd shots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2044 which adds a basic fud2 flow for Cider 2, named
interp-flat.Also some minor tweaks to make the code a little nicer in a few places. I need to go implement
withbefore I can get much of the test suite hooked up, since nearly all the test suite programs use it in some capacity