Explicitly use UTF8 encoding for media metadata table #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this can only happen at initial server creation, I think adding code to detect malformed database just for this would be wasteful. The hoster should just DROP and CREATE the database again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the ER_TOO_LONG_KEY error on creation of the media_metadata_cache table because databases that default to full 4-byte
utf8mb4encoding make theVARCHAR(255)idcolumn larger than the maximum supported key binary length of 767 bytes by MySQL and MariaDB RDBMS's.Resolves #860