blobs: switch from hyper to reqwest #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
reviewed
Nov 15, 2018
steveej
force-pushed
the
blobs-use-reqwest
branch
from
c92cdef
to
41695ee
Compare
TL;DR: It does now, thanks for pointing this out 😄 I thought it already did because I was able to trigger an error when I cross tested the changes from cincinnati, but I must've made a mistake while testing it |
steveej
force-pushed
the
blobs-use-reqwest
branch
from
41695ee
to
836a934
Compare
steveej
force-pushed
the
blobs-use-reqwest
branch
from
faa3def
to
ba70f72
Compare
lucab
reviewed
Nov 15, 2018
This change is motivated by improved statuscode handling. Instead of reimplementing this here we can make use of the reqwest library which already does it.
steveej
force-pushed
the
blobs-use-reqwest
branch
2 times, most recently
from
d58f92e
to
f432cf9
Compare
…ient_error
The introduced code returns an error if the status code in the success
range. Before this change even error codes would be treated as success
and the HTTP body, likely an error description from the server, would be
misused as an image blob.
In accordance with [RFC2068][1] the body should be displayed to the user
on client errors. For usability we include a UTF8 decoded version since
it's likely to yield something human readable, e.g.:
```rust
ErrorMessage { msg: "could not download blob: GET request failed with
status \'404 Not Found\' and body of size 233: \"<!DOCTYPE HTML PUBLIC
\\\"-//W3C//DTD HTML 3.2 Final//EN\\\">\\n<title>404 Not
Found</title>\\n<h1>Not Found</h1>\\n<p>The requested URL was not found
on the server. If you entered the URL manually please check your
spelling and try again.</p>\\n\"" }'
```
[1]: https://www.freesoft.org/CIE/RFC/2068/89.htm
steveej
force-pushed
the
blobs-use-reqwest
branch
from
f432cf9
to
dc3734f
Compare
This was referenced Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by improved status error handling.
Before this change even error codes would be treated as success and the
body would contain the HTML formatted error message passed through to
the caller.
Instead of reimplementing proper error handling here we can make use of
the reqwest library which already does it.
Closes #63
Progress on #44