Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pull in openssl. #86

Closed
wants to merge 1 commit into from
Closed

Don't pull in openssl. #86

wants to merge 1 commit into from

Conversation

khuey
Copy link

@khuey khuey commented Jan 24, 2019

I'm not sure if you actually need TLS for reqwest but if you do lets not pull in openssl since you're already using rustls.

@lucab
Copy link
Member

lucab commented Jan 25, 2019

@khuey thanks, it makes sense. I think longer term we are going to use reqwest only (#44), at which point we should just re-expose its TLS-related feature knobs to consumers.

@steveej steveej self-requested a review February 5, 2019 14:08
@lucab lucab mentioned this pull request Feb 8, 2019
Merged
@lucab
Copy link
Member

lucab commented Feb 8, 2019

@khuey heads in case you are using this somewhere. We completed the switch to reqwest and removed direct usage of hyper-rustls. #96 allows to switch the underlying TLS library, reaching the same goal of this PR.

@steveej steveej closed this in #96 Feb 8, 2019
@khuey
Copy link
Author

khuey commented Feb 11, 2019

Thanks!

@khuey khuey deleted the no-openssl branch February 11, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucab lucab lucab approved these changes

@steveej steveej Awaiting requested review from steveej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khuey @lucab