Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_codeowners_file #24

Merged
merged 1 commit into from
Oct 5, 2023
Merged

update_codeowners_file #24

merged 1 commit into from
Oct 5, 2023

Conversation

PedroDiez
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

PR to include as codeowners Sebastian and Giorgios.
More Codeowners can be included in future

Which issue(s) this PR fixes:

Fixes #10

Special notes for reviewers:

N/A

@PedroDiez PedroDiez self-assigned this Oct 3, 2023
@PedroDiez PedroDiez added the subproject management Indicating issues with subproject repository or release management process label Oct 3, 2023
Copy link
Collaborator

@jordonezlucena jordonezlucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PedroDiez PedroDiez requested review from a user and grgpapadopoulos October 5, 2023 08:47
@PedroDiez
Copy link
Collaborator Author

@grgpapadopoulos, @sebKoeller FYI I will comment today and merge after meeting

@PedroDiez PedroDiez merged commit 29e0faa into main Oct 5, 2023
@PedroDiez
Copy link
Collaborator Author

Merged after meeting

@ghost
Copy link

ghost commented Oct 5, 2023

@PedroDiez
Why is this showing an error?

@MarkusKuemmerle
Copy link
Collaborator

MarkusKuemmerle commented Oct 5, 2023 via email

@PedroDiez
Copy link
Collaborator Author

image

Hi, maybe missing something. GIT checking indicates the file is valid, isn't?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subproject management Indicating issues with subproject repository or release management process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main WG participants have subscription enabled
4 participants